Add curated tags to addons (3/9) [A thru C]#18863
Merged
lsiepel merged 10 commits intoopenhab:mainfrom Jul 4, 2025
Merged
Conversation
andrewfg
added
the
enhancement
andrewfg
requested review from
a team,
3cky,
AntonJansen,
BobRak,
GerdZanker,
MrRonfo,
blafois,
cdjackson,
cpmeister,
david-pace,
digitaldan,
gedejong,
jpharvey,
kaikreuzer,
mhilbush,
paphko,
paulianttila,
ssalonen and
weymann
as code owners
andrewfg
changed the title
Member
|
LGTM for |
david-pace
approved these changes
Jun 28, 2025
andrewfg
changed the title
andrewfg
changed the title
9 tasks
andrewfg
changed the title
AntonJansen
approved these changes
Jun 28, 2025
Contributor
AntonJansen
left a comment
AntonJansen
left a comment
There was a problem hiding this comment.
[broadlink] changes are okay.
lsiepel
reviewed
Jun 30, 2025
bundles/org.openhab.binding.buienradar/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
lsiepel
requested changes
Jul 4, 2025
Contributor
lsiepel
left a comment
lsiepel
left a comment
There was a problem hiding this comment.
Looked at all files. Left these comments, otherwise LGTM
bundles/org.openhab.binding.automower/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.bluetooth.ruuvitag/src/main/resources/OH-INF/thing/ruuvitag.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.boschshc/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.broadlink/src/main/resources/OH-INF/thing/channels.xml
Show resolved
Hide resolved
bundles/org.openhab.binding.broadlink/src/main/resources/OH-INF/thing/channels.xml
Show resolved
Hide resolved
bundles/org.openhab.binding.broadlink/src/main/resources/OH-INF/thing/channels.xml
Show resolved
Hide resolved
…F/thing/thing-types.xml Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
…ces/OH-INF/thing/ruuvitag.xml Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
…F/thing/channels.xml Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
…/thing/thing-types.xml Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Contributor
Author
|
@lsiepel it is ready to go now. Many thanks for reviewing. |
Contributor
Almost, it needs spotless due to build error |
Contributor
Author
|
@lsiepel ok all is good this time. |
lsiepel
removed
the
enhancement
phenix1990
pushed a commit
to phenix1990/openhab-addons
that referenced
this pull request
Jul 31, 2025
* initial Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Aug 6, 2025
* initial Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Paul Smedley <paul@smedley.id.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
In PR #18585 we applied tags to about 350 addons. They were applied by a machine algorithm that tries to guess the appropriate tags based on context in the channel-type xml files. The results of the algorithm are perhaps only about 80% .. 90% accurate.
Furthermore there is another problem in that some of our reviewers are unwilling to review #18585 due to its size.
Solution
In this PR we take over the remaining addons from #18585 whose names start with A thru C and apply my personal curated human improvements to them; although unfortunately we have not received any feedback from actual code owners.
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch
As mentioned these addons have already been reviewed and curated by myself .. so this is for OH Maintainers to keep track of their reviews..